Update tsconfig for Node 20 #10403
Merged
Update tsconfig for Node 20 #10403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
eddeee888
commented
Aug 13, 2025
| @@ -1,6 +1,6 @@ | |||
| module.exports = { | |||
| presets: [ | |||
| ['@babel/preset-env', { targets: { node: process.versions.node.split('.')[0] } }], | |||
| '@babel/preset-typescript', | |||
| ['@babel/preset-typescript', { allowDeclareFields: true }], | |||
There was a problem hiding this comment.
We use babel-jest, so we need this to understand declare keyword needed by tsconfig version of Node 20
eddeee888
commented
Aug 13, 2025
| @@ -691,7 +691,7 @@ export class BaseResolversVisitor< | |||
| TRawConfig extends RawResolversConfig = RawResolversConfig, | |||
| TPluginConfig extends ParsedResolversConfig = ParsedResolversConfig | |||
| > extends BaseVisitor<TRawConfig, TPluginConfig> { | |||
| protected _parsedConfig: TPluginConfig; | |||
| protected declare _parsedConfig: TPluginConfig; | |||
There was a problem hiding this comment.
Without this, declare keyword, TS will throw error:
Property '_parsedConfig' will overwrite the base property in 'BaseVisitor<TRawConfig, TPluginConfig>'. If this is intentional, add an initializer. Otherwise, add a 'declare' modifier or remove the redundant declaration.ts(2612)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is based on https://github.com/tsconfig/bases/blob/main/bases/node20.json
Note:
bobhas mapping toes2022when building for ESM, so we cannot setmoduleormoduleResolutionlike the base Node 20 exampleRelated #10218